Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove the gradient from form fields #6200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: remove the gradient from form fields #6200

wants to merge 2 commits into from

Conversation

vladboisa
Copy link
Contributor

Description

This PR fixes #6199

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@vladboisa
refactor: remove the gradient from form fields
d4cf0db 
Signed-off-by: Vlad Boisa <60569670+vladboisa@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Jan 21, 2025

🚀 Preview for commit d4cf0db at: https://678f20027eb45ba394360fe1--layer5.netlify.app

leecalcote
leecalcote requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please ensure that we are using some sort of color other than straight white, which in dark mode is offensive to the eyes.

@leecalcote
Copy link
Member

Thanks so much for working on this, @vladboisa 👍

@vladboisa
chore: swap color from straight white;
d7f1744 
Signed-off-by: Vlad Boisa <60569670+vladboisa@users.noreply.github.com>
@vladboisa
Copy link
Contributor Author

Thank you. Please ensure that we are using some sort of color other than straight white, which in dark mode is offensive to the eyes.

Yep, no problem. I think Off White (#FAF9F6): The Soft Touch fit's perfectly here! :)
Thanks for opportunity to help the Open-source community.

@l5io
Copy link
Contributor

l5io commented Jan 24, 2025

🚀 Preview for commit d7f1744 at: https://67930d06f95947544b6f77cc--layer5.netlify.app

@vladboisa vladboisa requested a review from leecalcote January 24, 2025 04:22
@vishalvivekm
Copy link
Contributor

Thank you for your contribution! @vladboisa
Let's discuss this during the website call on Monday at 7 AM CT.

adding it as an agenda item to the meeting minutes.

vishalvivekm
vishalvivekm requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladboisa
take a look at following screenshots:
from: https://67930d06f95947544b6f77cc--layer5.netlify.app/company/contact

  • invisible text [in dark theme]
    Screenshot from 2025-01-27 16-21-45
  • light theme
    Screenshot from 2025-01-27 16-21-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm vishalvivekm requested changes

@leecalcote leecalcote Awaiting requested review from leecalcote

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[form] remove the gradient from form fields
4 participants
@vladboisa @l5io @leecalcote @vishalvivekm